-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tracking prompt accessibility #2217
Conversation
Put buttons last in markup; move clarification message behind a Popover
2ff367e
to
6dedf4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
==========================================
+ Coverage 22.99% 23.81% +0.82%
==========================================
Files 141 142 +1
Lines 4393 4531 +138
Branches 746 771 +25
==========================================
+ Hits 1010 1079 +69
- Misses 2852 2904 +52
- Partials 531 548 +17
Continue to review full report at Codecov.
|
{ __( 'Usage data is completely anonymous, does not include your post content, and will only be used to improve the editor.' ) } | ||
</Popover> | ||
) } | ||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move the popover out from the button and use aria-expanded
on the button based on the showInfoPopover state. See for example post-visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think then we need another container element with position: relative
to hold the button and the popover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think that's the reason why a wrapper element was added around button and popover in the post-visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nylen ! just a coupe small things.
e2956fe
to
3601ee3
Compare
Thanks! |
Fixes #2215.
Popover
componentaria
attributes for the "More info" buttonedit: outdated screenshots removed; see below