Add align class to pull quote in editor #21756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
draganescu
changed the title
Closed
|
Size Change: +12 B (0%) Total Size: 842 kB
ℹ️ View Unchanged
|
adamziel
approved these changes
Apr 30, 2020
|
Actually, I don't think we should be adding this class. While ideally, the frontend matches the backend, the only exception right now is the alignment classes. They are not added on any block. The reasons for this are complex and I'll try to summarize them as: "we need special markup in the editor to make alignments work across themes" so in the editor we rely on We do have an issue to rethink alignments (and hopefully simplify them and make use of frontend markup 1-1) but that's a bigger undertaking #20650 I guess this is me saying that we should revert this PR and close the issue. |
draganescu
added a commit
that referenced
this pull request
Apr 30, 2020
This reverts commit a805410.
6 tasks
draganescu
added a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12853
How has this been tested?
Tested locally by:
Types of changes
Non breaking change affecting only the editor.