[ CoreData Entities ] add support for delete operations #21557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.01 MB (87%) 🏆 Total Size: 1.15 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
add/delete-items-nav-items-php
branch
from
40bb71d to
26a70f8
Compare
|
I've added a As a quick fix we could not use entities :) or otherwise we need the delete option in place. In absence, the delete works but on switching between menus the cache wrongly shows deleted menu items too. cc @noisysocks |
draganescu
force-pushed
the
add/delete-items-nav-items-php
branch
2 times, most recently
from
43edd43 to
f010401
Compare
draganescu
force-pushed
the
add/delete-items-nav-items-php
branch
from
f010401 to
ffb83d4
Compare
adamziel
reviewed
May 5, 2020
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
adamziel
reviewed
May 5, 2020
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
adamziel
requested changes
May 5, 2020
draganescu
requested review from
ajitbohra,
chrisvanpatten,
mkaz,
nerrad and
youknowriad
as code owners
noisysocks
previously requested changes
May 6, 2020
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
6 tasks
draganescu
changed the title
adamziel
force-pushed
the
add/delete-items-nav-items-php
branch
from
93c0e09 to
c6896f7
Compare
|
@draganescu I think I got it to work, the culprit was the |
draganescu
changed the title
draganescu
commented
May 18, 2020
packages/edit-navigation/src/components/menu-editor/use-navigation-blocks.js
Outdated
Show resolved
Hide resolved
|
This is looking really good! We need to add unit tests for the two new actions ( Let's also add a note to |
adamziel
force-pushed
the
add/delete-items-nav-items-php
branch
from
7f3aa1e to
c059655
Compare
|
@draganescu I rebased, tested a few scenarios, and here's what happened:
|
|
Apparently nested items break the deletions and it appears to be a bug in the hook because all the nested items get deleted. |
* adds delete menu with entity delete * updates the delete and removes the stateMenus * passes the new force query param * fix bug with resetting current menu after delete
draganescu
force-pushed
the
add/delete-items-nav-items-php
branch
from
d91d165 to
5abdf63
Compare
epiqueras
requested changes
Jun 30, 2020
…removed useless string conversion
epiqueras
requested changes
Jul 2, 2020
epiqueras
requested changes
Jul 9, 2020
Co-authored-by: Enrique Piqueras <epiqueras@users.noreply.github.com>
…ms action also improves tests and made sure the notifications always have unique ids
epiqueras
requested changes
Jul 14, 2020
epiqueras
requested changes
Jul 16, 2020
epiqueras
requested changes
Jul 17, 2020
- test delete for final shape when generator is done - simplify filter removing items from query
epiqueras
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for delete operations to entities. For a testing example use #22428
Screenshots
Types of changes
New feature to the entity actions and reducers that enable one to call
delete[EntityName]