-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove array of paragraphs structure from the text block #2133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
+ Coverage 22.93% 22.99% +0.05%
==========================================
Files 142 142
Lines 4403 4393 -10
Branches 749 745 -4
==========================================
Hits 1010 1010
+ Misses 2859 2853 -6
+ Partials 534 530 -4
Continue to review full report at Codecov.
|
Did you check the transformations to/from text? |
Yeah. Did you encounter problems? |
@iseulde no I haven't had the time to test the branch yet. It's just that when I do this kind of changes, I often miss the switcher and have to fix it afterwards. Will check the branch a bit later. |
This works great for me but there's the Heading to Text transformation we could update to drop all the multi-paragraph logic, it should be way simpler now 👍 |
dc87852
to
c740563
Compare
@youknowriad Did some cleaning up.
|
Is this good to go? |
Waiting for a review :) |
I noticed a small bug, not certain that it was introduced by this PR, but when transforming a quote with one paragraph and without a citation, we should just create a text block and not a text block and an empty quote |
@youknowriad I see this errors atm in master and works here? Still creates an empty code, but didn't change the logic there... |
c740563
to
0f3ebf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iseulde ok let's merge this, it resolves the master errors and we could remove the empty quote later
This seems to be a remainder from the multi paragraph structure. Currently this causes a bug with the placeholders as well when initialising the editor: