FSE: Use slug for template part display label #21161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Enhancement
noahtallen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
53 tasks
|
Size Change: +24 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
LGTM code wise, maybe @mtias could chime-in about the displayName
|
We are already using the title attribute here, why can't we use that?
|
|
@mtias That's the same thing, we're using |
|
omg |
|
yes, we need to add "labels" for the templates and template parts but the way they are written now. We'd need to support similar comments to the php templates in order to be able to define these from themes and also provide a UI to set this label in the Edit Site page. |
mtias
approved these changes
Mar 26, 2020
vindl
approved these changes
Mar 26, 2020
|
wow, 3 approvals in < 24 hours, it must be a new record! will rebase to try to get the tests passing. I can't merge without all passing checks :/ |
noahtallen
force-pushed
the
add/slug-for-template-part-label
branch
from
7baa4e7 to
2d3d7a9
Compare
|
I also added |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the slug attribute for template part block display label.
Thoughts:
Screenshots
Types of changes
Resolves #21104
Checklist: