Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element: Fix serializer handling of multiple distinct contexts #21156

Closed
wants to merge 6 commits into from
Closed

Element: Fix serializer handling of multiple distinct contexts #21156

wants to merge 6 commits into from

Commits on Mar 26, 2020

  1. Element: Fix serializer handling of multiple distinct contexts

    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    6313fad View commit details
    Browse the repository at this point in the history

  2. Element: Add non-mixed test case for nested context

    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    90dacf0 View commit details
    Browse the repository at this point in the history

  3. Element: Add testt case for rendering Context directly 

    Not officially valid, yet technically supported in React's implementation.

See: https://github.com/facebook/react/blob/a16b34974508cd23ce0844ad09a0e37a879d5591/packages/react-dom/src/server/ReactPartialRenderer.js#L1158-L1160
    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    014e884 View commit details
    Browse the repository at this point in the history

  4. Element: Guard property access to context consumer _context 

    Multiple references in React's codebase check whether this is assigned.

See: https://github.com/facebook/react/blob/a16b34974508cd23ce0844ad09a0e37a879d5591/packages/react-dom/src/server/ReactPartialRenderer.js#L1157

It's not entirely clear the exact circumstances this may occur at this point in code. Ideally there would be a test case verifying failure without this guard.
    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    947a58f View commit details
    Browse the repository at this point in the history

  5. Try common Map implementation

    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    c64b80a View commit details
    Browse the repository at this point in the history

  6. Try avoiding explicit argument to constructor

    @aduth
    aduth committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    621789b View commit details
    Browse the repository at this point in the history