-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pricing table pattern #20644
Add pricing table pattern #20644
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Hi @mtias 👋 Wondering if you have any comments about this pattern. Let me know if you think it can be improved or if we should close this PR instead. |
I think this is close, but can use a bit more design adjustments.
|
@mapk Another iteration: What do you think about the list block used for the plan features? It seemed like the most obvious block to use, but there's not much styling that can be applied to it. Also, I'm using the spacer block to try and match the height of the three columns, which is why they don't have perfectly equal height. |
This looks good for what we can currently achieve in Gutenberg. I like the direction. Let's merge it. |
96b2fb3
to
c13f563
Compare
@enriquesanchez I noticed you did some more visual updates. Can you share a screenshot? One for the editor and one for the frontend. 🙏 |
47bf549
to
66510d9
Compare
Inserter:Editor:Front-end:Not sure what to do about the layout issue on the inserter. I can make the font smaller but that would obviously affect the front-end. This may also be a case of fine-tuning how we render previews in the inserter. Most patterns feel very tall and narrow. Is there something that could be done @youknowriad? |
This should be refined so that the preview is strong before we merge it. If we can't get it there, @enriquesanchez, I suggest we just not merge this one. |
Yes, @mtias opened this issue #22147 where we could choose a width per pattern solving this. |
Looks like #22216 will let us fix the preview issues. |
51103f9
to
e295668
Compare
@mapk Now that (The missing separator on the 1st column is a preview artifact, but it is there). I'm still not 100% satisfied with how the columns preview with uneven heights, but the output does look much better: |
Adds a Pricing table section block pattern for #20345.