Remove !important override from Buttons block #20433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekhrabe
requested review from
ajitbohra,
Soean and
talldan
as code owners
|
Size Change: -7 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
|
This looks like the Unless @jorgefilipecosta knows of anything, then it seems like removing the |
|
Yeah, just wondering the cause of adding |
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
approved these changes
Feb 25, 2020
|
The Travis CI errors with this message:
It doesn't look related in any way but it's failing quite consistently for me. Can I still merge or should I retry until I might have a good luck? |
|
Hi @marekhrabe, I merged the change. |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 26, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 2, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the Buttons block in #17352 has broken previews because it adds
!importantto setting the appender to display it as an inline block. Previews try their best to hide UI like this but adding the!importanthas prevented that from working.Is it necessary? I have briefly tested the Buttons block without
!importantand there seems to be no obvious glitch happening. However, as the usage of the!importantdidn't seem to have been commented, I'm not sure what to look for and where it potentially breaks.cc: @jorgefilipecosta as the original author
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: