Prefer @wordpress/icons over dashicons in docs and tests #20094
Conversation
youknowriad
requested review from
adamsilverstein,
ajitbohra,
chrisvanpatten,
ellatrix,
gziolo,
jorgefilipecosta and
mkaz
as code owners
youknowriad
added
the
[Type] Code Quality
packages/edit-post/src/components/header/plugin-more-menu-item/index.js
Outdated
Show resolved
Hide resolved
packages/edit-post/src/components/header/plugin-more-menu-item/index.js
Outdated
Show resolved
Hide resolved
| focusable="false" | ||
| height={20} | ||
| role="img" | ||
| viewBox="0 0 20 20" |
There was a problem hiding this comment.
Do we have changes that adjust CSS for a different size?
Ignore if yes. I’m on mobile and it’s hard to scroll 😅
There was a problem hiding this comment.
I don't get the question :) I changed the icon here so it's a different viexbox
There was a problem hiding this comment.
Lol, it's hard to explain. Dashicons have a different size than SVG icon but I think it's handled by the fact that you no longer use Dashicon here. Ignore me :)
There was a problem hiding this comment.
Yes, for dashicons that are still used we use a trick in viewport (-2) to center them properly even if they're smaller.
|
Nice. What’s the plan for server- side registration of icons? It looks like we are deprecating strings as a way to list them. |
Should be a harmless PR just updating icons used in docs and tests