Polish block UI, inspector, add contributors, fix quote styles #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2017
Merged
|
On full-width blocks there's a slight overlap with the border:
|
mtias
approved these changes
Jul 27, 2017
|
Addressed the feedback, and also surfaced the mover in fullwide. Because why not.
Merging when the checks pass. |
This will be an ongoing task. Anyone should feel free to add.
This makes it the same as that of the block code, which fixes issues, and makes it more maintainable.
This makes it the same as the block code, making it easier to maintain and fixing issues.
Some pixels here, a few there. A background for when no block is selected. All good.
This makes the mover (left) and cog/trash button (right) have the same margins and paddings, simplifying the appearance a bit.
Like with the other prompts and titles, this rewrites the responsive code so it is easier to maintain (same as elsewhere), and fixes issues.
Because why not.
jasmussen
force-pushed
the
polish/ui-docs-various
branch
from
b1192b1 to
d34aff1
Compare
|
Rebased. Will wait again. |
Yes, good call. |
|
On some breakpoints the arrows overlap:
Also it removes the mobile toolbar for wide blocks :)
|
|
Ack, need to revisit that. Okay. |
Fix issue with movers overlapping, and with mobile toolbar being broken on wide.
I couldn't think of any side-effects to this.
Only showed when settings was closed.
|
Looks good to me now. |
|
Thanks. Merging. Travis needs work anyway. |
|
Okay maybe I should have waited for the tests to finish, my apologies. I was under the impression travis was totally broken, when in fact it's probably only partially broken. |
This was referenced Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a kitchen sink PR to fix a lot of lingering little issues.
Normalization
The biggest issues fixed here are the normalization of block paddings and margins between the title, the empty placeholder, and the below the placeholder elements. These now share basically the same styles, which means they behave identically at responsive breakpoints (fixing issues), but the normalization also makes the code easier to maintain.
Steps to test: View the editor at multiple responsive breakpoints (resize the window), and verify that
Other
Mover and cog/trash elements now have the same dimensions, and fit nicely within the smallest block (a single empty paragraph). This means the mover up/down arrows are spaced a little farther apart, but it gives some nice symmetry. Verify it looks good ;)
Quote styles were fixed, there was a CSS bleed regression from a recent tinymce update. To test, verify lineheights and margins for anything that uses the Editable component didn't regress from this fix.
The inspector was polished a bit to remove double borders, tweak the close button padding, and add a white background when no block is selected.
The contributors document was updated with recent contributors. I know it's a bummer that this isn't automated, but it means we can give credit to contributors who test, mock up and other things.