Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block: reposition tabbable inserter #19596

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jan 13, 2020

Description

Unblocks #19322.

This PR moves the tabbable inserter before the block toolbar.
In the future we can polish this by perhaps centring the button and add one below the block as well.

Why before the toolbar? Because technically you don't leave the block until you exit the block toolbar, and the inserter buttons make most sense on the edges of the block, before and after the block.

The following button normally invisible. It's only visible on focus.

Screenshot 2020-01-13 at 14 12 08

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ellatrix
Copy link
Member Author

Chatted with @MarcoZehe and we agreed that it makes sense for the inserter to be positioned before the block toolbar (in tab order) as this makes it more clearer that it's not a block control. if this is not good, we can always change the tab position but keep the visual position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants