Navigation Block: Define allowedFormats option for NavigationLink #19507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
frontdevde
added
[Block] Navigation
frontdevde
approved these changes
Jan 8, 2020
|
@MDWolinski |
|
Removed my comment and put it on #18318. |
|
@WunderBart could you take another look at this please? The change prevents custom formats / buttons from being added to the menu item toolbar. I've reported it here: ..but I am not sure how to get that ticket 'triaged'. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines the
allowedFormatsprop for theNavigationLinkcomponent. As discussed in #18318, theInline Codeoption will no longer be available.How has this been tested?
Check formatting options for a navigation item - they should include only:
BoldItalicInline imageStrikethroughScreenshots
Types of changes
Non-breaking change. If the
Inline codeformatting was used for nav item before it will still render as inline code in both editor and view, but the option will no longer be available.Closes: #18318