Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Test Utils: Try improved stability for transformBlockTo #18771

Merged
merged 2 commits into from
Nov 27, 2019
Merged

E2E Test Utils: Try improved stability for transformBlockTo #18771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fba6ef
E2E Test Utils: Try improved stability for transformBlockTo
aduth Nov 26, 2019
65ab68c
E2E Test Utils: Use canonical `block-editor-` switcher classname
aduth Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/e2e-test-utils/src/transform-block-to.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,31 @@
/**
* Internal dependencies
*/
import { pressKeyWithModifier } from './press-key-with-modifier';

/**
* Converts editor's block type.
*
* @param {string} name Block name.
*/
export async function transformBlockTo( name ) {
await page.mouse.move( 200, 300, { steps: 10 } );
await page.mouse.move( 250, 350, { steps: 10 } );
await page.click( '.block-editor-block-switcher__toggle' );
const insertButton = ( await page.$x(
`//button//span[contains(text(), '${ name }')]`
) )[ 0 ];
// Transition to block toolbar by key combination.
await pressKeyWithModifier( 'alt', 'F10' );

// Press Enter in the focused toggle button.
const switcherToggle = await page.waitForSelector( '.block-editor-block-switcher__toggle:focus' );
await switcherToggle.press( 'Enter' );

// Find the block button option within the switcher popover.
const switcher = await page.$( '.block-editor-block-switcher__container' );
const insertButton = ( await switcher.$x( `//button[.='${ name }']` ) )[ 0 ];

// Clicks may fail if the button is out of view. Assure it is before click.
await insertButton.evaluate( ( element ) => element.scrollIntoView() );
await insertButton.click();

// Wait for the transformed block to appear.
const BLOCK_SELECTOR = '.block-editor-block-list__block';
const BLOCK_NAME_SELECTOR = `[aria-label="Block: ${ name }"]`;
// Wait for the transformed block to appear.
await page.waitForSelector(
`${ BLOCK_SELECTOR }${ BLOCK_NAME_SELECTOR }`
);
await page.waitForSelector( `${ BLOCK_SELECTOR }${ BLOCK_NAME_SELECTOR }` );
}