Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNMobile: Remove unneeded/duplicate css #18759

Merged
merged 2 commits into from
Jan 16, 2020
Merged

RNMobile: Remove unneeded/duplicate css #18759

merged 2 commits into from
Jan 16, 2020

Conversation

mchowning
Copy link
Contributor

Description

This is some css cleanup that was included as a part of the fix for wordpress-mobile/gutenberg-mobile#992 in https://github.com/wordpress-mobile/gutenberg-mobile/pull/1560/files.

How has this been tested?

Inusure that the following components display properly with no excess padding:

  • post-title
  • heading
  • paragraph
  • floating-toolbar

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mchowning mchowning requested a review from maxme November 26, 2019 17:07
@mchowning mchowning added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 26, 2019
@mchowning mchowning mentioned this pull request Nov 26, 2019
Merged
1 task
@maxme maxme marked this pull request as ready for review December 2, 2019 15:55
maxme
maxme reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good when tested in the wpandroid and wpios, or in the example app. Thanks for looking into that @mchowning

packages/block-editor/src/components/block-list/block-mobile-floating-toolbar.native.scss
@@ -1,3 +1,5 @@
$floating-toolbar-height: 44;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I checked we only used this one here.

packages/block-library/src/heading/edit.native.js
@@ -38,10 +37,7 @@ const HeadingEdit = ( {
identifier="content"
tagName={ 'h' + attributes.level }
value={ attributes.content }
style={ {
...style,
minHeight: styles[ 'wp-block-heading' ].minHeight,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we had that in the first place. I searched the file history, and unfortunately it comes from a big merge. Maybe @Tug knows better if this is safe to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it comes from this PR (related gb-mobile PR).
From what I understand it was used to fix a bug/inconsistency in Aztec related to the placeholder not being displayed when no content was given. I'm not sure if this has been fixed in Aztec, maybe @marecar3 knows? Otherwise @mchowning might have tested it and made sure that was not an issue before removing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checked and the placeholders are showing up for headings, paragraphs, etc. for me.

@maxme
Copy link
Contributor

maxme commented Dec 9, 2019 •
edited
Loading

Note a recent PR #18155 for gallery introduced the use of min-height-paragraph.

@mchowning
Copy link
Contributor Author

Note a recent PR #18155 for gallery introduced the use of min-height-paragraph.

Tested and it looks like that min-height-paragraph can be safely removed, so I pushed a commit doing that.

maxme
maxme approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: - I'll update the gb-mobile PR

@mchowning mchowning force-pushed the rnmobile/issue/992-remove-extra-padding-in-text-blocks branch from 29bf5ff to b0dd531 Compare January 10, 2020 16:00
marecar3
marecar3 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here!
LGTM!

@mchowning mchowning force-pushed the rnmobile/issue/992-remove-extra-padding-in-text-blocks branch from b0dd531 to 0337520 Compare January 16, 2020 19:38
@mchowning mchowning merged commit 434f32f into master Jan 16, 2020
@mchowning mchowning deleted the rnmobile/issue/992-remove-extra-padding-in-text-blocks branch January 16, 2020 20:05
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug left review comments

@marecar3 marecar3 marecar3 approved these changes

@maxme maxme maxme approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@mchowning @maxme @Tug @marecar3 @ellatrix