jest-puppeteer-axe: add options and config parameters
#18712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
gziolo
added
[Package] Jest Puppeteer aXe
gziolo
reviewed
Nov 26, 2019
There was a problem hiding this comment.
Nice idea to expose those additional parameters.
It would be great to polish documentation as the number of options offered makes it harder to use for those not familiar with Axe.
This PR will also require new entry in the CHANGELOG file, it should be similar to:
https://github.com/WordPress/gutenberg/blob/master/packages/jest-puppeteer-axe/CHANGELOG.md#new-feature
gziolo
added
the
First-time Contributor
gziolo
reviewed
Nov 27, 2019
gziolo
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way to specify AXE options and config, see https://github.com/dequelabs/axe-puppeteer#axepuppeteeroptionsoptions-axerunoptions and https://github.com/dequelabs/axe-puppeteer#axepuppeteerconfigureconfig-axespec