chore: Fix: Paragraph block isRTL may not be boolean #18526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
Soean and
talldan
as code owners
|
Without this straightforward change, it is hard to test the widgets screen in other PR's, so I am going to merge this. If there is any suggestion, anyone would like to make, please leave a comment, and I will open a follow-up PR. |
jorgefilipecosta
deleted the
fix/paragraph-block-isRtl-may-not-be-a-boolean
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the block editor provider does not provide an isRTL setting, isRTL may be undefined.
ParagraphRTLToolbar returns
isRTL && (...), so it may return undefined making the block crash.It is possible to see this problem by opening the widget block screen and trying to use a paragraph, as the widgets screen does not provide an isRTL setting.
Widgets screen should provide isRTL that will be fixed in a different PR, but the paragraph block should not rely on isRTL being available, so this PR still fixes a problem.
How has this been tested?
I opened the widget blocks screen.
I added a paragraph, wrote something, and verified the paragraph did not crash.