Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserves style of menu items when in edit mode #18367

Merged
merged 4 commits into from
Nov 8, 2019

Conversation

draganescu
Copy link
Contributor

Description

Closes #18331

How has this been tested?

Tested locally

Screenshots

Screenshot 2019-11-07 at 13 46 56

Types of changes

Removed some CSS from the editor css of the navigation menu item component. Made the font styling inherit.

@mtias mtias added [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Nov 7, 2019
@draganescu draganescu changed the title fixes look of editing menu items Preserves style of menu items when in edit mode Nov 8, 2019
@draganescu draganescu force-pushed the fix/menu-item-edit-styles branch from c837e45 to 4bdf63d Compare November 8, 2019 10:26
@mtias
Copy link
Member

mtias commented Nov 8, 2019

For completeness, this was fixed before and regressed in #18172 cc @retrofox

@mtias
Copy link
Member

mtias commented Nov 8, 2019

All red, I like it :)

Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@draganescu draganescu merged commit eba7de4 into master Nov 8, 2019
@draganescu draganescu deleted the fix/menu-item-edit-styles branch November 8, 2019 12:33
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking into menu item shows border
5 participants