(i18n) Verse: Example: Fix string concatenation, add translators string

[mcsf]

Description

See #18364 for full context. In particular, this pull request explores the following point:

However, when dealing with block examples, we are in the unusual case of translating not UI, not code in a stricter sense, but serialised data representing user content. Thus, the example strings can in fact contain HTML elements. In fact, I'd argue that this is the most correct thing to do, as it fits the idea that we're letting content be translated.

[ellatrix]

Hm, why are we adding line break elements vs. using \n?

[ellatrix]

Now that I look closer, it looks like this block is could use the same logic as Preformatted to replace line breaks.

[ellatrix]

What do you think about #18372?

[mcsf]

Thanks for jumping in.

What do you think about #18372?

I don't have a preference, only the sense that one change is more complex than the other. Do you see a strong reason against using <br>? Or did you mean to fix Verse to allow \n regardless of the block example issue?

[ellatrix]

It depends how you see it. The change is slightly (?) more complex, but the benefit is that it's less complex to translate (don't have to deal with line break elements), what is saved is less complex, it's less complex to edit the HTML in the HTML editor, and it would make the implementation the same as the Preformatted block.

[mcsf]

Those all make sense, but especially the parallels with Preformatted. We can go with your PR.

[ellatrix]

Ah, parallel. That's the word I was looking for. :)

[ellatrix]

But I don't mind doing this first and then the other. It doesn't really matter. :)

[mcsf]

Thanks for the review! Will circle back to #18372.