-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Site Editing: Add experimental SiteDescription block #18241
Full Site Editing: Add experimental SiteDescription block #18241
Conversation
c785ac7
to
f65e5dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested these changes on my docker environment.
This block seems to work well in both the editor and front end running the Twenty Twenty theme.
I am a little unfamiliar on how theme support for FSE works here, but I do notice if I switch to an older theme like 'Twenty Eleven' that this block is still accessible but does not allow for much customization such as width, etc. Is it worth restricting access to blocks like this to FSE enabled themes only? (or are all themes technically FSE enabled when we run the experimental plugin and some just don't have as much support as others?)
@Addison-Stavlo Thanks for reviewing! 🙇 Currently Core FSE don't really have a theme/front end side yet, and Core FSE blocks are only gated behind the (Core) FSE experiment. (Also please notice that this PR depends on #18361) |
@Copons is this still blocked? |
@carolinan Things have changed a lot in the last many months, and I'm afraid I might mess up something while rebasing. |
Replaced by #23788 |
Description
Add a
SiteDescription
block similar toSiteTitle
but with styling attributes like text and background colors, text and block alignments, and font size.Note: this depends on #18238 which enhances the
PlainText
component with a fewRichText
-like features. Should we decide thePlainText
refactor is not worth it, it's fairly easy to change this to useRichText
without allowed formats (see the WordPress.com implementation).How has this been tested?
Tested on the Docker environment with the Full Site Editing experiment enabled.
Since the FSE experiment replaces the theme, to test this on the front end is necessary to create a template (Appearance > Templates) with
index
as slug, that will render as the themeindex.php
file.Screenshots
Note: the font size difference is caused by the theme (Twenty Twenty). For some reasons, the larger font size is 32px in the editor and 42px in the front end.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: