Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for WordPress 5.3 RC 3 #18131

Merged
merged 5 commits into from
Oct 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ branches:
only:
- master
- rnmobile/master
- wp/trunk
- /wp\/.*/

env:
global:
Expand Down
2 changes: 1 addition & 1 deletion packages/api-fetch/src/middlewares/media-upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function mediaUploadMiddleware( options, next ) {
return next( { ...options, parse: false } )
.catch( ( response ) => {
const attachmentId = response.headers.get( 'x-wp-upload-attachment-id' );
if ( ( response.status === 500 || response.status === 502 ) && attachmentId ) {
if ( response.status >= 500 && response.status < 600 && attachmentId ) {
return postProcess( attachmentId ).catch( () => {
if ( options.parse !== false ) {
return Promise.reject( {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/list/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export default function ListEdit( {
className={ className }
placeholder={ __( 'Write list…' ) }
onMerge={ mergeBlocks }
onSplit={ ( value ) => createBlock( name, { ordered, values: value } ) }
onSplit={ ( value ) => createBlock( name, { ...attributes, values: value } ) }
__unstableOnSplitMiddle={ () => createBlock( 'core/paragraph' ) }
onReplace={ onReplace }
onRemove={ () => onReplace( [] ) }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,25 @@
.is-hidden {
display: none;
}


// Until checkboxes WordPress-wide are updated to match the new style,
// checkboxes used in metaboxes have to be slightly unstyled here.
// @todo: remove this entire rule once checkboxes are the same everywhere.
// See: https://github.com/WordPress/gutenberg/issues/18053
.postbox-container .postbox input[type="checkbox"],
.postbox-container .postbox input[type="radio"] {
border: $border-width solid $dark-gray-300;

&:checked {
background: $white;
border-color: $dark-gray-300;
}

&::before {
margin: -3px -4px;
}
}
}

.edit-post-meta-boxes-area__clear {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ function useAutosavePurge() {
const lastIsAutosaving = useRef( isAutosaving );

useEffect( () => {
if ( lastIsAutosaving.current && ! isAutosaving && ! didError ) {
if (
! didError && (
( lastIsAutosaving.current && ! isAutosaving ) ||
( lastIsDirty.current && ! isDirty )
)
) {
localAutosaveClear( postId );
}

Expand Down