Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run 2 tasks at once during Travis JS build #1808

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented Jul 8, 2017

Recent Travis build times look highly variable:

The change in pattern here coincides with switching to Jest in #1382.

After adding coverage reporting in #1783, we are putting even more stress on the Travis CI container that runs the JavaScript CI job. It's effectively running 4 jobs at once:

  • npm run build
  • npm run lint
  • Jest, worker 1
  • Jest, worker 2

(Jest will use 2 workers because our Travis containers have 2 cores and Jest defaults to 1 worker per core.)

This PR changes the CI job to run only two concurrent tasks:

  • npm run lint, then npm run build
  • Jest (only one worker)

I'll run a few builds against this PR and use the same travis-stats app to verify that build times are shorter and/or more consistent.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.964% when pulling af9e4651cebdaa40bc74793eb1ebd8f791def630 on update/travis-parallel-commands into 8284fa6 on master.

Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.816% when pulling 9d11d47 on update/travis-parallel-commands into d157b5e on master.

@nylen nylen merged commit 19e84ca into master Jul 10, 2017
@nylen nylen deleted the update/travis-parallel-commands branch July 10, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants