[WIP][RNMobile][FIX] floating toolbar for the first element in a group #17769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
koke
reviewed
Oct 4, 2019
packages/block-editor/src/components/block-list/block.native.js
Outdated
Show resolved
Hide resolved
pinarol
added
the
Mobile App - i.e. Android or iOS
pinarol
reviewed
Oct 7, 2019
packages/block-editor/src/components/block-list/block-mobile-floating-toolbar.native.scss
Outdated
Show resolved
Hide resolved
pinarol
reviewed
Oct 7, 2019
packages/block-editor/src/components/block-list/block-mobile-floating-toolbar.native.js
Outdated
Show resolved
Hide resolved
pinarol
reviewed
Oct 7, 2019
packages/block-editor/src/components/block-list/block-mobile-floating-toolbar.native.js
Outdated
Show resolved
Hide resolved
pinarol
reviewed
Oct 7, 2019
There was a problem hiding this comment.
Although this is working super smooth on Group it doesn't produce desired results on Media & Text. We can merge this PR since it makes some things better but still we'll need to address the problem on media & text :(
Could you please add a logic to show FloatingToolbar on Group block only?
|
Closing for now. It will be open when work over the fix resumes. |
lukewalczak
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a phase 2 of #17399
In this PR I fixed the floating toolbar for the first element in a group to be rendered above the block and be clickable.
gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#1409
How has this been tested?
Check if each of floating toolbar in a group block is clickable and rendered in the correct place
Screenshots
Types of changes
bug fix
Checklist: