-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add/social block movers #17701
WIP: Add/social block movers #17701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The movers seem to work well. This PR applies with success the API being implemented in #16615, I left some comments on the API on the other PR.
For reference this is how the movers look on social links:
This moves to flex instead of grid, neutralizes margins, simplifies a few things.
50a4be4
to
f5827db
Compare
Ah, nice! Let's rebase when #16615 gets merged. Based on the GIF, this one is close, but needs a little love with regards to how the horizontal mover looks. Based on the GIF it looks like it's not quite as tall as it needs to be, which I fixed in 16615, and that it needs a little less space to the left. Both things I can fix easily, but I'd like to wait for the rebase to make sure I'm not duplicating work. Very cool. |
I am going to close this branch and do it again once the horizontal mover PR is in master. |
Description
Depends on #16615
Implements movers for the Social Icons Block.
How has this been tested?
Enabled the option and tested locally
Screenshots
Types of changes
Checklist: