Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As per suggestion margin removed fixes #1744 #1756

Closed
wants to merge 1 commit into from

Conversation

nishitlangaliya
Copy link

Fixes-1744

As per suggestion margin removed from blocks-editable__tinymce

Thanks

@nylen
Copy link
Member

nylen commented Jul 6, 2017

All changes to code must be tested before submitting.

It looks like you didn't test this change. It makes the original issue worse rather than better:

2017-07-06t22 14 00 0200

It also breaks the appearance of core/text blocks by adding the same extra padding there:

2017-07-06t22 16 22 0200

By "remove margins for more p elements inside the editor" I mean setting the margins to zero rather than simply deleting CSS rules.

Please install https://github.com/nylen/gutenberg-boilerplate-es5 and insert some of its "Hello World" blocks so that you can see the problem.

@nylen nylen closed this Jul 6, 2017
Tug pushed a commit that referenced this pull request Jan 16, 2020
* Add locale to lowercase operation

* Use Locale.ROOT instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants