Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the Social Links plugin as experimental. #17526

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Mark the Social Links plugin as experimental. #17526

merged 4 commits into from
Sep 24, 2019

Conversation

nicolad
Copy link
Member

@nicolad nicolad commented Sep 23, 2019 •
edited
Loading

Description

Applies feature flag as required here

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@nicolad nicolad added [Priority] High Used to indicate top priority items that need quick attention [Feature] Blocks Overall functionality of blocks [Block] Social Affects the Social Block - used to display Social Media accounts labels Sep 23, 2019
@nicolad nicolad requested review from youknowriad and mkaz September 23, 2019 13:33
youknowriad
youknowriad reviewed Sep 23, 2019
View reviewed changes
packages/block-library/src/index.js Outdated
@@ -171,5 +171,7 @@ export const __experimentalRegisterExperimentalCoreBlocks = process.env.GUTENBER
__experimentalEnableLegacyWidgetBlock ? legacyWidget : null,
__experimentalEnableMenuBlock ? navigationMenu : null,
__experimentalEnableMenuBlock ? navigationMenuItem : null,
__experimentalEnableLegacyWidgetBlock ? socialLink : null,
__experimentalEnableLegacyWidgetBlock ? socialLinks : null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nicolad

Maybe we can just use process.env.GUTENBERG_PHASE === 2 as a test instead of __experimentalEnableLegacyWidgetBlock because If I'm not mistaken, this will ensure the block is always loaded in the plugin but not included in Core.

Can you confirm @talldan ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youknowriad, updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Sep 23, 2019
@mkaz
Copy link
Member

mkaz commented Sep 23, 2019

Also, I think socialLink itself is not a block, but you need ...socialLink.sites to get all the individual blocks.

@nicolad
Copy link
Member Author

nicolad commented Sep 23, 2019

Also, I think socialLink itself is not a block, but you need ...socialLink.sites to get all the individual blocks.

Thanks @mkaz

@nicolad nicolad requested a review from youknowriad September 24, 2019 07:48
youknowriad
youknowriad approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@youknowriad youknowriad merged commit 20cde36 into master Sep 24, 2019
@youknowriad youknowriad deleted the feature-flag/social-links branch September 24, 2019 17:22
@nicolad nicolad self-assigned this Sep 29, 2019
@youknowriad youknowriad added this to the Gutenberg 6.6 milestone Sep 30, 2019
youknowriad pushed a commit that referenced this pull request Sep 30, 2019
@nicolad @youknowriad
Mark the Social Links plugin as experimental. (#17526)
e024217
youknowriad pushed a commit that referenced this pull request Sep 30, 2019
@nicolad @youknowriad
Mark the Social Links plugin as experimental. (#17526)
12de1ff
@jorgefilipecosta jorgefilipecosta removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@mkaz mkaz Awaiting requested review from mkaz

Assignees

@nicolad nicolad

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Blocks Overall functionality of blocks [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Milestone
Gutenberg 6.6
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolad @mkaz @youknowriad @talldan @jorgefilipecosta