Fix fixtures for MS Word, and properly handle newlines #17459
Conversation
tfrommen
added
[Type] Bug
tfrommen
requested review from
ellatrix,
gziolo and
youknowriad
as code owners
| return; | ||
| } | ||
|
|
||
| node.innerHTML = node.innerHTML.replace( /(?<!<br>)\n/g, ' ' ); |
There was a problem hiding this comment.
Are we trying to strip line breaks (\n)? Why should it not be preceded by a line break element?
There was a problem hiding this comment.
Well, yes! 🙂 This is exactly what this is about.
Please refer to the initial comment of the related issue.
This behavior, as well as the fix/handling for it, is specific to pasting content from MS Word. As you can see in the mentioned issue, MS Word copies content formatted with a maximum line-length of 80 characters. So there are newlines injected by MS Word itself. Any actual user-defined linebreak is actually a <br>, followed by a newline. And we do not want to replace that.
Does that make sense?
| return; | ||
| } | ||
|
|
||
| if ( ! [ ...node.classList ].find( ( className ) => className.match( /^Mso[A-Z].*/ ) ) ) { |
There was a problem hiding this comment.
Do you think this is a unique MS Word problem? More specifically a paragraph problem? In my opinion, we should be writing a general line break (\n) collapser, as line breaks (\n) in HTML are not visible in any circumstance. The are only used to format the HTML.
There was a problem hiding this comment.
There are, for sure, other tools that do weird things with line breaks. However, this PR (and the related issue) is specific to pasting content from MS Word, where one gets additional line breaks that have been injected by MS Word itself.
It might be true that HTML, or rather the browser, doesn't care about newlines. But they will also end up in content.raw in the REST API response. And this is where things can break.
There was a problem hiding this comment.
Yes, there are other sources that may inject line breaks. That's why I'm suggesting to look for a more general fix. See #17470.
|
With #17470 merged, closing now. |
Description
This is a fix for #13497.
If you copy-paste text from MS Word, this will result in unwanted newlines in the pasted and processed content.
How has this been tested?
See #13497 (comment) and #13497 (comment).
In this PR, I also updated and expanded fixtures.
Types of changes
Update and fix (!) some fixtures, and include a new RAW paste handler.
Checklist: