Make BlockNavigationList component experimental #17446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Task
talldan
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean and
youknowriad
as code owners
youknowriad
reviewed
Sep 15, 2019
| @@ -16,7 +16,7 @@ import { __ } from '@wordpress/i18n'; | |||
| */ | |||
| import BlockIcon from '../block-icon'; | |||
|
|
|||
| export default function BlockNavigationList( { | |||
| export default function __experimentalBlockNavigationList( { | |||
There was a problem hiding this comment.
Do you think we can keep the name as is internally and just rename the one exported in the public API?
There was a problem hiding this comment.
@youknowriad Yep, that's now been changed 👍
youknowriad
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the new
BlockNavigationListcomponent to be experimental while it's in development.Types of changes
Refactor