[RNMobile] Fix dismiss keyboard button for the post title #17149
Conversation
* Editor: Update the store to use Core Data entities. * Editor: Fix selector test suites. * Editor: Fix some legacy selectors and behaviors. * Editor: Fix action tests. * Editor: Fix remaining broken unit tests. * Editor: Fix more tests. * Editor: Fix more e2e test behaviors. * Editor: Fix preview functionality. * Core Data: Fix autosaves filtering. * Editor: Don't make entity dirty with initial edits. * Editor: Don't save if the post is not saveable. * Core Data: Fix merged edits logic. * Core Data: Fix undo to fit e2e expected behaviors. * Core Data: Handle more change detection and saving flows. * Block Editor: Fix undo level logic. * Core Data: Clean up undo reducer comment. * Editor: Make `serializeBlocks` a util. * Core Data: Clarify raw attribute usage. * Core Data: Memoize . * Core Data: Use new raw entity record selector instead of modifying the existing one. * Core Data: Make save notices the caller's responsibility. * Editor: Use the store key constant in actions instead of a string literal. * Editor: Defer serialization of blocks until save. * Editor: Fix raw content access in set up. * Editor: Revert broken test change. * Editor: Make initial edits a dirtying operation. * Editor: Add comment clarifying why we set content to a new function on edits. * Demo: Fix tests to consider the initial edits dirtying. * Core Data: Set auto-drafts to drafts when autosaving them. * Core Data: Handle receiving autosaves correctly when editing non-autosave-persisting-properties.
…nderers (WordPress#16512) * Add callbacks to ServerSideRenderer to handle failures * Update variable naming and set default renderers * LoadingResponsePlaceholder * swtich case * fetchComplete * Remove fetchcomplete method * Pass render props * add changelog entry * add documentation for new props
Previously, tapping at the end of the post would insert a block immediately after the currently selected block. In addition, this commit is cleaning out a few unusued props in the block-list file.
|
hi @geriux 👋 Thanks for the PR. This is working good 🎉 |
pinarol
added
the
Mobile App - i.e. Android or iOS
|
Hey @pinarol ! Sorry about that! Linting issues solved =) |
|
Thanks! |
|
We created a new working branch named |
|
Of course! I have a conflict after changing the base that I'll fix today =) |
geriux
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
gziolo,
jorgefilipecosta,
mkaz,
nerrad,
ntwb,
Soean,
talldan and
youknowriad
as code owners
|
@pinarol I see there are a lot of changes when I changed the base, did you mean maybe to make the changes from |
|
Basically we should base the changes of this PR on 'rnmobile/master' so that we are leaving breaking changes outside. Feel free to do this the easiest way you prefer, you can create a new branch from 'rnmobile/master' and cherry pick this changes onto it. |
|
Oh ok! I went ahead and did that, here's the new one. #17260 |
Related gutenberg-mobile PR
Description
This fixes an iOS and Android issue with the post title when it is in focus, the option to hide the keyboard wasn't working as expected (it should dismiss the keyboard)
Right now it was only clearing the selected blocks and not the post title so I changed it to dispatch both. If the number of different elements increases another approach should be implemented so it's easy to maintain.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: