Revert Clickthrough #16888
Closed
Revert Clickthrough #16888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c5e8784.
youknowriad
added
the
[Feature] Nested / Inner Blocks
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
nerrad,
ntwb,
Soean and
talldan
as code owners
|
@youknowriad I believe the clickthrough PR may have included something to speed up the addition/removal of the Trying this PR out now, I'm seeing those delays return:
|
This was referenced Aug 3, 2019
swissspidy
previously approved these changes
Aug 16, 2019
5 tasks
|
superseded by #17239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c5e8784.
Really sad to push that PR but I think the "clickthrough" experiment is not that succesfull especially when editing complex templates.
I had a number of conflicts when reverting, so I'd appreciate a sanity check for regressions.