Code

Try/even better previews#16873

Code

Merged

obenland merged 83 commits intomasterWordPress/gutenberg:masterfrom try/even-better-previewsWordPress/gutenberg:try/even-better-previewsCopy head branch name to clipboardAug 7, 2019

+217-82

Commits

Commits on Aug 2, 2019

• First stab at a proof of concept.

  

  Joen Asmussen

  authored and

  retrofox

  committed
  cdddad0

  Copy full SHA for cdddad0

• Attempt to programmatically determine dest dimensions

  

  getdave

  authored and

  retrofox

  committed
  af648b1

  Copy full SHA for af648b1

• Add README stub.

  

  jasmussen

  authored and

  retrofox

  committed
  2cc1264

  Copy full SHA for 2cc1264

• Updates to use default args for width and height

  Show description for 3ad0bc1
  

  getdave

  authored and

  retrofox

  committed
  3ad0bc1

  Copy full SHA for 3ad0bc1

• Update class namespaces to match package

  Show description for 3a15d94
  

  getdave

  authored and

  retrofox

  committed
  3a15d94

  Copy full SHA for 3a15d94

• Add width and height as Effect Hook deps

  Show description for 167fadb
  

  getdave

  authored and

  retrofox

  committed
  167fadb

  Copy full SHA for 167fadb

• Use correct createRef from @wordpress/element

  Show description for 68fb82f
  

  getdave

  authored and

  retrofox

  committed
  68fb82f

  Copy full SHA for 68fb82f

• Revert "Update class namespaces to match package"

  Show description for 2ae0507
  

  getdave

  authored and

  retrofox

  committed
  2ae0507

  Copy full SHA for 2ae0507

• Migrate to useRef hook

  

  getdave

  authored and

  retrofox

  committed
  a920ee5

  Copy full SHA for a920ee5

• Adds basic unit test

  Show description for dc8738f
  

  getdave

  authored and

  retrofox

  committed
  dc8738f

  Copy full SHA for dc8738f

• Refactor to avoid unecessary state and simplify implementation of scaling

  

  getdave

  authored and

  retrofox

  committed
  0f4f105

  Copy full SHA for 0f4f105

• Add some padding to the preview

  Show description for 62e1109
  

  getdave

  authored and

  retrofox

  committed
  62e1109

  Copy full SHA for 62e1109

• Refactor to utilise JS template strings

  

  getdave

  authored and

  retrofox

  committed
  e822ae7

  Copy full SHA for e822ae7

• WIP: Adds zoom for small individual blocks

  Show description for 04648b4
  

  getdave

  authored and

  retrofox

  committed
  04648b4

  Copy full SHA for 04648b4

• Updates to target block contents more reliably and to calc entire box model in width

  

  getdave

  authored and

  retrofox

  committed
  a6f6e38

  Copy full SHA for a6f6e38

• block-preview: render scaled preview in a shadow dom

  retrofox

  committed
  6f5c06f

  Copy full SHA for 6f5c06f

• try: setting styles to shadow dom elements

  retrofox

  committed
  ff88234

  Copy full SHA for ff88234

• Revert "try: setting styles to shadow dom elements"

  Show description for 770ff2d
  

  getdave

  authored and

  retrofox

  committed
  770ff2d

  Copy full SHA for 770ff2d

• Removes attempt at auto zoom on Block contents

  Show description for a55e988
  

  getdave

  authored and

  retrofox

  committed
  a55e988

  Copy full SHA for a55e988

• Updates to remove scale by default in favour of opt in via prop

  Show description for 7755b5b
  

  getdave

  authored and

  retrofox

  committed
  7755b5b

  Copy full SHA for 7755b5b

• Adds scaleFactor prop to provide control for non dynamically scaled preview

  

  getdave

  authored and

  retrofox

  committed
  94b6e3d

  Copy full SHA for 94b6e3d

• Adjust scaleFactor for Block Styles preview

  

  getdave

  authored and

  retrofox

  committed
  cffd2e8

  Copy full SHA for cffd2e8

• Fix to ensure hooks are called unconditionally to obey rules of Hooks

  Show description for 550f99e
  

  getdave

  authored and

  retrofox

  committed
  550f99e

  Copy full SHA for 550f99e

• Removes padding and border from preview on designer advice

  

  getdave

  authored and

  retrofox

  committed
  c5c7079

  Copy full SHA for c5c7079

• Only apply dimensions to preview content when dynamically scaling

  

  getdave

  authored and

  retrofox

  committed
  1489148

  Copy full SHA for 1489148

• block-preview: a different approach attempt.

  retrofox

  committed
  5649e51

  Copy full SHA for 5649e51

• Correct typo in util function name

  

  getdave

  authored and

  retrofox

  committed
  c4d3843

  Copy full SHA for c4d3843

• Seek the firstChild of the Block DOM node

  

  getdave

  authored and

  retrofox

  committed
  0bb1a30

  Copy full SHA for 0bb1a30

• Tidy up effect timers and improve comments

  

  getdave

  authored and

  retrofox

  committed
  8d77381

  Copy full SHA for 8d77381

• Dynamically calculate widths and offsets of preview container

  Show description for 4def132
  

  getdave

  authored and

  retrofox

  committed
  4def132

  Copy full SHA for 4def132

• Updates to account for widths of all Blocks passed into to preview

  Show description for ea1d096
  

  getdave

  authored and

  retrofox

  committed
  ea1d096

  Copy full SHA for ea1d096

• Revert class additions to Blocks

  

  getdave

  authored and

  retrofox

  committed
  02e69f5

  Copy full SHA for 02e69f5

• Adds optional scope to DOM utils. Use to limit scope in Block width comparison.

  

  getdave

  authored and

  retrofox

  committed
  52084af

  Copy full SHA for 52084af

• Update packages/block-editor/src/components/block-preview/index.js

  Show description for 6d0a85d
  

  2 peopleauthored and

  retrofox

  committed
  6d0a85d

  Copy full SHA for 6d0a85d

• Allow prop based opt out from scaling

  

  getdave

  authored and

  retrofox

  committed
  3ed1f99

  Copy full SHA for 3ed1f99

• Fix to ensure smallest Block is found even if smaller than container

  Show description for 7c86742
  

  getdave

  authored and

  retrofox

  committed
  7c86742

  Copy full SHA for 7c86742

• Remove unecessary Math.min usage

  

  getdave

  authored and

  retrofox

  committed
  efa2127

  Copy full SHA for efa2127

• core/button: adjust dims of button wrapper

  retrofox

  committed
  595cf03

  Copy full SHA for 595cf03

• apply vertical alignment

  retrofox

  committed
  6941688

  Copy full SHA for 6941688

• set scale factor to 0.9

  retrofox

  committed
  d7e7b4a

  Copy full SHA for d7e7b4a

• rollback testing purpose comment

  retrofox

  committed
  6a7c6d9

  Copy full SHA for 6a7c6d9

• cpre/button: keep adjusting styles for preview

  retrofox

  committed
  0fab9b2

  Copy full SHA for 0fab9b2

• rename vars and css class names

  retrofox

  committed
  0f0d6b8

  Copy full SHA for 0f0d6b8

• adjust rebase

  retrofox

  committed
  d11b6ab

  Copy full SHA for d11b6ab

• restore isScaled factor scale

  retrofox

  committed
  d39c1d7

  Copy full SHA for d39c1d7

• set the scale adjustment in the proper place

  retrofox

  committed
  55cd662

  Copy full SHA for 55cd662

• update README file

  retrofox

  committed
  b942fb9

  Copy full SHA for b942fb9

Commits on Aug 5, 2019

• core/button: tidy edit preview styles

  retrofox

  committed
  0ab14f8

  Copy full SHA for 0ab14f8

• coer/button: tweak button preview

  retrofox

  committed
  c86f750

  Copy full SHA for c86f750

• preview-block: ensure make the preview visible.

  retrofox

  committed
  18ded7d

  Copy full SHA for 18ded7d

• block-preview: hide dropzone

  retrofox

  committed
  0b7de16

  Copy full SHA for 0b7de16

• core/button: adjust preview for thumb and full sizes

  retrofox

  committed
  354d42c

  Copy full SHA for 354d42c

• core/button: set same width for preview

  retrofox

  committed
  d70011f

  Copy full SHA for d70011f

• core/button: because it's !important

  retrofox

  committed
  6089478

  Copy full SHA for 6089478

Commits on Aug 6, 2019

• core/button: set nowrap button in preview

  retrofox

  committed
  dbbe0bc

  Copy full SHA for dbbe0bc

• core/button: set nowrap onlu for button

  retrofox

  committed
  758468c

  Copy full SHA for 758468c

• core/quote: adjust quote size

  retrofox

  committed
  2b71c32

  Copy full SHA for 2b71c32

• Make previews overflow to the bottom.

  Show description for 65097d0
  obenland

  committed
  65097d0

  Copy full SHA for 65097d0

• Merge branch 'try/even-better-previews' of https://github.com/WordPress/gutenberg into try/even-better-previews

  obenland

  committed
  8bdcb8e

  Copy full SHA for 8bdcb8e

• Revert "core/button: set nowrap onlu for button"

  Show description for 6096c3e
  obenland

  committed
  6096c3e

  Copy full SHA for 6096c3e

• Fix unit test

  obenland

  committed
  e1b9483

  Copy full SHA for e1b9483

• core/button: apply nowrap only to buttons

  retrofox

  committed
  75d43ce

  Copy full SHA for 75d43ce

• Try a fixed canvas width

  youknowriad

  committed
  89f6393

  Copy full SHA for 89f6393

• Fix blocks editor styles

  youknowriad

  committed
  5a1e5ad

  Copy full SHA for 5a1e5ad

• core/button: centering preview

  retrofox

  committed
  3d47db8

  Copy full SHA for 3d47db8

• core/button: adjust only into teh styles preview

  retrofox

  committed
  27b430f

  Copy full SHA for 27b430f

• block-preview: remove scaleAdjustment property

  retrofox

  committed
  d21df0b

  Copy full SHA for d21df0b

• block-preview: hide inserte element in preview

  retrofox

  committed
  d8212f2

  Copy full SHA for d8212f2

• block-preview: just pick up the first block to scale

  retrofox

  committed
  2b1a111

  Copy full SHA for 2b1a111

• block-preview: fix set tall class. X position (wip)

  retrofox

  committed
  e50cfcb

  Copy full SHA for e50cfcb

• popover: remove commented lines

  retrofox

  committed
  5208a03

  Copy full SHA for 5208a03

Commits on Aug 7, 2019

• Refactor the preview

  youknowriad

  committed
  029e131

  Copy full SHA for 029e131

• Remove debug code

  youknowriad

  committed
  72c5027

  Copy full SHA for 72c5027

• simplify preview resets

  youknowriad

  committed
  a4958f3

  Copy full SHA for a4958f3

• Fix the preview recomputing

  youknowriad

  committed
  22b4d84

  Copy full SHA for 22b4d84

• Vertical alignining small blocks

  youknowriad

  committed
  f218f64

  Copy full SHA for f218f64

• block-editor: restore viewportWidth as a property

  retrofox

  committed
  835c4ba

  Copy full SHA for 835c4ba

• Update Readme docs

  Show description for 3fe45d7
  obenland

  committed
  3fe45d7

  Copy full SHA for 3fe45d7

• Remove tests for now

  Show description for 91f142f
  obenland

  committed
  91f142f

  Copy full SHA for 91f142f

• block-preview: simplify comparision

  retrofox

  committed
  33fb2d9

  Copy full SHA for 33fb2d9

• Merge branch 'try/even-better-previews' of github.com:WordPress/gutenberg into try/even-better-previews

  retrofox

  committed
  527111e

  Copy full SHA for 527111e

• Remove readme updates that break tests

  obenland

  committed
  6f29c27

  Copy full SHA for 6f29c27

• Update docs properly.

  Show description for a3bb473
  obenland

  committed
  a3bb473

  Copy full SHA for a3bb473