DropdownMenu: Fix shifting menu items #16871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix menu items in the More menu from shifting horizontally when selected.
noisysocks
added
[Type] Bug
noisysocks
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
I figured out that, it might have regressed in #14843. Although, we were mostly moving styles to different files during that refactoring. |
karmatosed
approved these changes
Aug 2, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Fix menu items in the More menu from shifting horizontally when selected.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Fix menu items in the More menu from shifting horizontally when selected.
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix menu items in the More menu from shifting horizontally when selected. This was noticed while testing #14851.
Before:
After:
I'm not really confident that I fixed this the right way. I'm unclear to me whether the margin between the text and icon is supposed to be
4pxperIconButton:gutenberg/packages/components/src/icon-button/style.scss
Line 25 in 5b01c97
Or if it's supposed to be
5pxperMenuItem:gutenberg/packages/components/src/menu-item/style.scss
Line 13 in 5b01c97
I could really use some of that @jasmussen magic right now! 🙏