Image Block: Use the figure wrapper for images with wide/full alignment #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's working for me 👍 👍
|
|
How about always adding the figure tag? I'm not sure why the alignment should cause different semantic tags. |
|
@iseulde this might be problematic with alignleft and alignright |
|
Why? |
|
because they should be inside the normal text float and should not break the paragraph |
|
It will still be floated correctly? I'm not sure if I understand the concern. Also, these cannot be inserted inside a paragraph, they're blocks. |
|
@iseulde I agree with always using figure, it should simplify the logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1665