Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow presentation from sandboxed iframe to fix error in Chrome #1657

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Allow presentation from sandboxed iframe to fix error in Chrome #1657

merged 1 commit into from
Jul 3, 2017

Conversation

notnownikki
Copy link
Member

No description provided.

jasmussen
jasmussen approved these changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Nice work! No errors in this branch! Thank you.

@notnownikki notnownikki merged commit fa445c0 into master Jul 3, 2017
@ellatrix
Copy link
Member

ellatrix commented Jul 3, 2017

I'm also seeing:

widgets.js:9 Blocked form submission to 'https://syndication.twitter.com/i/jot' because the form's frame is sandboxed and the 'allow-forms' permission is not set.

@mtias mtias deleted the fix/youtube-presentation-error branch July 7, 2017 17:26
@adamziel adamziel mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notnownikki @ellatrix @jasmussen