Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping editor notifications over admin submenus. #1630

Closed
wants to merge 2 commits into from
Closed

Overlapping editor notifications over admin submenus. #1630

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bffbf
Fix for overlapping editor notifications over admin submenus.
andreg Jul 1, 2017
eb28786
Fix notification overlapping admin submenus.
andreg Jul 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions editor/assets/stylesheets/_z-index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ $z-layers: (
'.editor-post-visibility__dialog': 30,
'.editor-post-schedule__dialog': 30,
'.editor-block-mover': 30,
'.components-notice-list': 100000,
'.components-popover': 100000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think popovers should show up over admin submenus.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so - the notice is part of the Gutenberg UI, not something that should block you from using other wp-admin functions.

The design of traditional WP notices is very different (inline with the page, rather than popovers) but they don't suffer from this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about the notices, I was talking about the popovers (They can be full width and have a grayed background to cover the rest of the page)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this a modal. The gray background should prohibit expanding the admin menus in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you open the inserter (which is a popover on a small screen), Should the inserter show up above or under the admin bar? I think it should be above

'.components-notice-list': 9989,
'.components-popover': 9989,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 9989? How high does this value actually need to be in order to make it work, and why? Let's avoid unnecessarily high values here, and if a specific value is needed, add a comment describing why.

See previous discussion about z-index values on #637 - these are more complicated than many people realize.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9989 was the exact value for the notification to fall exactly under the dropdown admin navigation menu, nothing more than that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a specific value is needed, add a comment describing why.

Something like this:

// Admin submenus (.wp-some-selector) have z-indez 9990

);

@function z-index( $key ) {
Expand Down