Revert "adds selection persistence on sidebar tab switch" #16042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d5998d.
aduth
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz,
nerrad,
notnownikki,
ntwb and
talldan
as code owners
aduth
added
the
[Release] Do Not Punt
youknowriad
approved these changes
Jun 7, 2019
|
Hi @aduth thanks for handling this. I was away since Friday sorry I couldn't help. I'll continue on the issue with a new PR trying a different approach :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15583
See #15583 (comment)
There are a few remaining issues with this implementation raised at #13309 (comment) and #13309 (comment), and some considered uncertainty around naming / APIs / treatment of selection states between document and block raised at #15583 (comment).
Let's plan to omit this from the upcoming Gutenberg 5.9 release, and aim to include it in the following with revisions to the original #15583.