Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the readme #1595

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Fix a typo in the readme #1595

merged 2 commits into from
Jun 30, 2017

Conversation

MehtaRiddhi
Copy link

@jasmussen

I have Fixed some content changes in README.md and CONTRIBUTING.md file.

@jasmussen
Copy link
Contributor

I appreciate your desire to contribute to Gutenberg, thank you!

However this is a fairly small change, and IMO not necessary.

@nylen
Copy link
Member

nylen commented Jun 30, 2017

The first comma is correctly placed.

The second one is a good typo fix:

editor focus in a core

Let's just take that second change, @MehtaRiddhi. Want to update this PR and get rid of the comma change?

@MehtaRiddhi
Copy link
Author

@nylen,

Thanks for your suggestion. I have updated my PR and just take the second change.

Please review it and let me know if anything.

Thanks,

@nylen
Copy link
Member

nylen commented Jun 30, 2017

Thanks for the fix!

@nylen nylen changed the title Fix some content changes Fix a typo in the readme Jun 30, 2017
@nylen nylen merged commit a01b2dd into WordPress:master Jun 30, 2017
@paulwilde
Copy link
Contributor

Umm, wasn't it already correct? This doesn't seem to make sense now.

@nylen
Copy link
Member

nylen commented Jun 30, 2017

"editor focus in core" is fine; the previous "editor focus in a core" makes me think of an apple or a nuclear reactor.

"editor focus in WordPress core" is perhaps better.

@paulwilde
Copy link
Contributor

paulwilde commented Jun 30, 2017

It was changed from "in [WordPress] core" to "in a core" though, not the other way.

So there wasn't an issue to begin with. :)

@nylen
Copy link
Member

nylen commented Jul 1, 2017

Ahhh! How did I misread that. Sorry guys :)

jasmussen added a commit that referenced this pull request Jul 3, 2017
Due to a misunderstanding, a tiny typo was merged. But it's worth reverting.
jasmussen added a commit that referenced this pull request Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants