Inserter: add tabs. #1582
Inserter: add tabs. #1582
Conversation
mtias
added
the
[Feature] Inserter
|
Sounds like we'd want fixed min-height with this change. |
editor/inserter/style.scss
Outdated
| @@ -137,6 +138,14 @@ input[type="search"].editor-inserter__search { | |||
| width: 100%; | |||
|
|
|||
| &.is-active { | |||
| border-bottom: 2px solid #f00; | |||
| background: $white; | |||
| border-bottom: 2px solid $blue-medium-500; | |||
There was a problem hiding this comment.
Not a big deal, but this is cleaner if it were just border-bottom-color: $blue-medium-500.
|
See #1574 regarding the fade out bug. It's unrelated to this pull request. |
|
I'm seeing a couple of visual issues. Firstly on Safari 10.1.2 there is some top/bottom margin. Adding
Secondly, the active state turns the text colour to white. |
|
I personally prefer it visually if the active tab and content bleed together. I have the CSS written that achieves this and fixes the bugs mentioned above if interested.
|
|
Thanks for the feedback, addressed most of it. I think we should address the white bleeding in to the tab separately, as we are likely to move the tabbar around a bit: #1325 (comment) I also relaxed the margins and paddings a bit:
|
- Recent, blocks, and embeds. - Displays different sets of blocks. Don't show category header for single category display.
Address feedback.
Also restyle the separator heading.
Adds recent, blocks, and embeds.
See #1325.