Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS block: Remove PHP 5.2 compatibility code #15806

Merged
merged 1 commit into from
Nov 28, 2019
Merged

RSS block: Remove PHP 5.2 compatibility code #15806

merged 1 commit into from
Nov 28, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented May 24, 2019

Description

This PR removes PHP 5.2 compatibility code from the RSS widget.

Before we merge we have to require min. WordPress 5.2.

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed labels May 24, 2019
@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels May 24, 2019
@Soean Soean mentioned this pull request May 24, 2019
Merged
youknowriad
youknowriad approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

I wonder if there are other things we can remove where php code moved to Core and is useless in the plugin now.

@Soean Soean merged commit 41877ef into master Nov 28, 2019
@Soean Soean deleted the update/rss-block-remove-old-php-code branch November 28, 2019 18:44
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@notnownikki notnownikki Awaiting requested review from notnownikki

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Soean @youknowriad @gziolo