Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SlotFill documentation and examples #15738

Merged
merged 51 commits into from
May 23, 2019

Conversation

ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented May 20, 2019

Description

This PR aims to improve the documentation and examples for SlotFill based on work done in https://github.com/10up/slotfill-and-filter-demos

Types of changes

Documentation

Checklist:

  • I've included developer documentation if appropriate.

@oandregal
Copy link
Member

These docs are great, thanks @ryanwelcher!

I was thinking, though: what if we add this to a new section in the handbook called "Slot Reference"? I believe it would give them more visibility: it is an important concept that isn't covered in the reference docs yet although we do have a tutorial and component docs. It'd fit well just after the "Filter Reference" section almost verbatim, and the "existing slots" could be subsections that we'd add as new slots are implemented.

What do you think?

@ryanwelcher
Copy link
Contributor Author

ryanwelcher commented May 20, 2019

@nosolosw that would work for me. One of the issues I'm running into is adding an image for each of the slotsFills because the docs get auto-generated.

I've started adding them into the docs now and should have this PR updated soon.

ryanwelcher and others added 18 commits May 23, 2019 08:16
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ttings-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…lish-panel.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…tus-info.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…ish-panel.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…more-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
@ryanwelcher
Copy link
Contributor Author

@nosolosw thanks for the review and suggestions on this!
I have merged your changes, updated the toc.json file, and rebuilt the manifest.

ryanwelcher and others added 2 commits May 23, 2019 08:55
…more-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
…more-menu-item.md

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
@oandregal oandregal self-requested a review May 23, 2019 15:16
Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and follow-up on the block-editor SlotFills. I'm merging this as soon as Travis would let us.

@oandregal
Copy link
Member

This is a great improvement to the handbook, thanks for getting this in @ryanwelcher ! 🌟

@oandregal oandregal merged commit 514e612 into WordPress:master May 23, 2019
@youknowriad
Copy link
Contributor

Awesome work here 👍

@youknowriad youknowriad added this to the 5.8 (Gutenberg) milestone May 24, 2019
@ryanwelcher
Copy link
Contributor Author

Glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants