Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list start, reversed settings (in progress) #15113

Merged
merged 5 commits into from
Aug 15, 2019
Merged

Add list start, reversed settings (in progress) #15113

merged 5 commits into from
Aug 15, 2019

Commits on Aug 15, 2019

  1. Squash for easier merge: 

    f6ad4f07e6a1c8d99e55aa7acb01cf8ef1dfddd7 (HEAD -> update/list-block, Jackie6/update/list-block) Add id to BaseControl
212cab106044c4d7300d9441e48241b911db0bcb Fix unit test and e2e test
421a198bf58431c91b4c09d6ee45ba932762cb15 Refine the type definition of start and reversed
4172707059558ba9fc47d9557457e0b8e441f050 Fix typo
21ed1dbeb7881a9a5a6eea85fb3293e9d6ba0d5a Update CSS styles
925f1ab1ed073b31358a129c62abd56021e14c38 Update list type style and remove description
ef0aca95cb88203ceff78b81473e37ad8fc22714 Allow the start to be NaN
495166d3fc14591ceb88597915a19e976b2ebbeb Change to check strict equality
216ca51cfacfc174ca00d9669b88b53eaa6d0356 Fix the accidental change of travis yml
8e31259624ece930c385bf9cb7a28046505c7aff Change local state to attributes
09199ff9516aab099e47ed6e61fd4e2fadfdb95b Add list type, start, reversed settings
    @ellatrix
    ellatrix committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    3fbf11f View commit details
    Browse the repository at this point in the history

  2. Revert adding attribute for now, let's extract to a separate PR

    @ellatrix
    ellatrix committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    7d4d355 View commit details
    Browse the repository at this point in the history

  3. Use proper TextControl

    @ellatrix
    ellatrix committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    a7ce233 View commit details
    Browse the repository at this point in the history

  4. Adjust toggle control to unset attribute

    @ellatrix
    ellatrix committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    fa184ef View commit details
    Browse the repository at this point in the history

  5. Clearer label

    @ellatrix
    ellatrix committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    a31f4c6 View commit details
    Browse the repository at this point in the history