Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gap in figcaption backround gradient #14731

Merged
merged 1 commit into from
Apr 1, 2019
Merged

fix gap in figcaption backround gradient #14731

merged 1 commit into from
Apr 1, 2019

Conversation

m-e-h
Copy link
Member

@m-e-h m-e-h commented Mar 31, 2019 •
edited
Loading

Description

In #14366 a bottom margin was added to all figcaptions.

This broke figcaptions on gallery-items.
This PR fixes that by removing the margin-bottom declaration.

Not having a bottom margin was discussed on the original PR but I think was forgotten about.
#14366 (comment)

I'm also wondering if the margin-bottom: 1em on figcaption is necessary.
If the block has a margin-bottom, the figcaption's margin-bottom does nothing. Even without a specific margin on the block, figure gets a margin-bottom: 1em from the browser.

I first discovered this regression while investigating #14674
This does not resolve that issue.

How has this been tested?

Visually all blocks look the same after this change. Except of course the gallery block.

Screenshots

Screenshot_2019-03-29 Gut Check – one wordpress test

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@m-e-h m-e-h requested a review from chrisvanpatten as a code owner March 31, 2019 18:43
@m-e-h m-e-h changed the title remove unnecessary bottom margin from figcaption fix gap in figcaption backround gradient Mar 31, 2019
@jasmussen jasmussen added this to the 5.5 (Gutenberg) milestone Apr 1, 2019
@jasmussen jasmussen self-requested a review April 1, 2019 08:27
jasmussen
jasmussen approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Apr 1, 2019
@youknowriad youknowriad merged commit fcbeecc into WordPress:master Apr 1, 2019
noisysocks pushed a commit that referenced this pull request Apr 3, 2019
@m-e-h @noisysocks
remove unnecessary bottom margin from figcaption (#14731)
916a158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
5.4 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@m-e-h @jasmussen @youknowriad