Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Regenerate package-lock.json #14646

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 26, 2019

This pull request seeks to regenerate the package-lock.json per the results of npm install using the latest version of NPM (6.9.0).

See:

Testing instructions:

Verify there are no local changes after running npm install.

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Mar 26, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This going back and forth between versions of npm 😃

@aduth
Copy link
Member Author

aduth commented Mar 26, 2019

This going back and forth between versions of npm 😃

Wondering if latest versions of npm are dependable enough that we could get rid of the "forgiveness" we include for optional, since at the time it was primarily a difference of OS (Travis Linux).

https://github.com/WordPress/gutenberg/blob/master/bin/process-git-diff.js

If we did that, even unexpected changes in optional would be marked by check-local-changes.

@aduth aduth merged commit 59b03c0 into master Mar 26, 2019
@aduth aduth deleted the fix/regenerate-package-lock-14548 branch March 26, 2019 19:58
@gziolo
Copy link
Member

gziolo commented Mar 27, 2019

https://npm.community/t/package-lock-json-keeps-changing-between-platforms-and-runs/1129/16 - I found the related topic, the last report is from January, so it's hard to say whether it's fixed. We can give it a try and see if it is still an issue as it obviously prevents us from catching other issues.

@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants