[RNMobile] Fix for Heading block on ENTER.key to create empty paragraph #14642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eading block, and create an empty paragraph after it.
daniloercoli
added
the
Mobile App - i.e. Android or iOS
daniloercoli
deleted the
rnmobile/Enter-on-Heading-block-creates-another-Heading-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem on mobile where pressing enter at the end of a Heading block, it does create another Heading block. Ref: wordpress-mobile/gutenberg-mobile#734
Expectation: Pressing enter on a Heading block, should create a Paragraph block. Same as on any other "split-able block)
To test this PR, use the following gb-mobile branch here: wordpress-mobile/gutenberg-mobile#787