Add checked attribute to FormToggle. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Focus] Accessibility (a11y)
youknowriad
reviewed
Jun 26, 2017
components/form-toggle/index.js
Outdated
| @@ -28,6 +28,7 @@ function FormToggle( { className, checked, id, onChange = noop, showHint = true | |||
| id={ id } | |||
| type="checkbox" | |||
| value={ checked } | |||
There was a problem hiding this comment.
I think we should probably drop the value
youknowriad
reviewed
Jun 26, 2017
| @@ -17,15 +17,13 @@ describe( 'FormToggle', () => { | |||
| expect( formToggle.hasClass( 'components-form-toggle' ) ).to.be.true(); | |||
| expect( formToggle.hasClass( 'is-checked' ) ).to.be.false(); | |||
| expect( formToggle.type() ).to.equal( 'span' ); | |||
| expect( formToggle.find( '.components-form-toggle__input' ).prop( 'value' ) ).to.be.undefined(); | |||
There was a problem hiding this comment.
could we replace .prop( 'value' ) with .prop( 'checked' ) instead of dropping the assertions?
youknowriad
approved these changes
Jun 26, 2017
youknowriad
pushed a commit
that referenced
this pull request
Jan 17, 2020
…f-crash Fix(?) crash when removing media-text blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like screen readers, and presumably also other software, rely on the
checkedattribute to correctly announce the checkboxes state. Please refer to the screenshots on the issue.To test:
Fixes #1435