Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an red screen when pasting in mobile. #14010

Closed
wants to merge 9 commits into from

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 21, 2019

Description

Fixes a red screen that would come up when trying to paste plain text at the end of a block or when text was selected.

How has this been tested?

Through this PR: wordpress-mobile/gutenberg-mobile#638

Types of changes

Made some small changes to the rich-text component code in the native files.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@diegoreymendez diegoreymendez added [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices labels Feb 21, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 21, 2019
@diegoreymendez
Copy link
Contributor Author

Closing as this was based off the wrong branch.

@diegoreymendez diegoreymendez deleted the issue/624-pasting-into-selected-text branch February 21, 2019 15:14
@etoledom
Copy link
Contributor

Hey @diegoreymendez - Just a small note. You can press the edit button at the right side of the title and change the base branch 👍

@diegoreymendez
Copy link
Contributor Author

diegoreymendez commented Feb 21, 2019

@etoledom - That's useful only if you hadn't merged master into your PR though.

PS: Although to be honest there weren't other changes than the submodule, but still, starting over doesn't hurt either.

@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants