-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes an red screen when pasting in mobile. #14010
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set
…eters returned onChange, and we forgot to update the PostTitle component (#13967)
Upload media progress bar is missing while media is uploading new
diegoreymendez
added
[Type] Bug
An existing feature does not function as intended
Mobile Web
Viewport sizes for mobile and tablet devices
labels
Feb 21, 2019
Closing as this was based off the wrong branch. |
Hey @diegoreymendez - Just a small note. You can press the edit button at the right side of the title and change the base branch 👍 |
@etoledom - That's useful only if you hadn't merged master into your PR though. PS: Although to be honest there weren't other changes than the submodule, but still, starting over doesn't hurt either. |
gziolo
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
and removed
Mobile Web
Viewport sizes for mobile and tablet devices
labels
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a red screen that would come up when trying to paste plain text at the end of a block or when text was selected.
How has this been tested?
Through this PR: wordpress-mobile/gutenberg-mobile#638
Types of changes
Made some small changes to the rich-text component code in the native files.
Checklist: