-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test transform from media to embed blocks #13997
Conversation
I added the mocking of audio and image test URLs and also used the video URL which was already mocked. |
088083c
to
ad23c70
Compare
The undo tests seem to fail for everyone on travis, for some they work on local. Ran locally they fail because of a timeout. Interestingly, setting the timeout to be higher using both Running in playback mode results in the same timeout, although visual inspection shows undo does work! |
Yes, the Undo tests are very unstable at the moment. I'm hoping this is improved with #14108. |
…s in to embeds when embeddable URLs are provided
ad23c70
to
2cce5c2
Compare
rebased and changed @noisysocks requested changes |
Looks like Travis might be reporting a legitimate test failure:
|
@noisysocks @youknowriad this now passes all checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I trust Travis it works :)
…rnmobile/887-History-stack-is-not-empty-on-a-fresh-start-of-the-editor * 'master' of https://github.com/WordPress/gutenberg: Reset embed mocks on every request, stop request to instagram (#15046) Refactor core blocks to have save and transforms in their own files (part 2) (#14899) Fix pullquote import (#15036) Refactor core blocks to have save and transforms in their own files (part 4) (#14903) Refactor core blocks to have save and transforms in their own files (part 3) (#14902) Refactor core blocks to have deprecated extracted to their ownf files (p.1) (#14979) Test transform from media to embed blocks (#13997) If a more recent revision/autosave exists, store its state on editor setup (#7945) chore(release): publish
Closes #11901
Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided
Description
Added e2e tests to test the transform of audio, video and image blocks in to embeds when embeddable URLs are provided
Checklist: