Do not render font size picker when no font sizes are available and custom font sizes are disabled #13844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom font sizes are disabled.
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
added
the
Good First Review
jorgefilipecosta
deleted the
fix/do-not-display-font-size-picker-if-not-font-sizes-are-available-and-custom-fontsizes-are-disable
branch
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…ustom font sizes are disabled. (#13844)
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
…ustom font sizes are disabled. (#13844)
This was referenced Apr 30, 2020
This was referenced May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the theme sets an empty array as font sizes and disables custom font sizes the user is not able to select any font size so the font size picker should not render.
How has this been tested?
I added the following code snippet in functions.php:
I added a paragraph, and I verified the font size picker does not appear.
Screenshots
Before:
After:
