Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta box link to new tutorial #13302

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Update meta box link to new tutorial #13302

merged 4 commits into from
Jan 22, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Jan 12, 2019

Description

Updates links in Developer overview to new tutorial explaining how to use meta boxes. The new tutorial section includes the previous link to the backward compatibility documentation.

Changed it this way since we want to encourage the development of meta boxes using the new Gutenberg methods, so updating the link to go to the tutorial first; with a subsequent link to the backward compatibility.

Types of changes

Documentation.

@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Jan 12, 2019
@mkaz mkaz self-assigned this Jan 12, 2019
Fix link. Simplify URLs.

## Meta Boxes

**Porting PHP meta boxes to blocks or sidebar plugins is highly encouraged!**

Discover how [Meta Box](../../../docs/designers-developers/developers/backward-compatibility/meta-box.md) support works in the new editor.
Discover how to work with [Meta Boxes](/docs/designers-developers/developers/tutorials/metabox/readme.md) in the new editor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still link to the meta-box backcompat docs because it explains how legacy meta boxes currently work and how we handle backward compatibility.

Alternately, we should at least make sure to link to both files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to include two paragraphs, tying in the encouragement to the new tutorials and rewording the previous one for clarity, ie. "existing meta boxes"

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some two link to filters which were broken.

@gziolo gziolo merged commit 8fdf3cd into master Jan 22, 2019
@gziolo gziolo deleted the docs/meta-link branch January 22, 2019 08:49
@gziolo gziolo added this to the Documentation & Handbook milestone Jan 22, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Update meta box link to new tutorial

* Update README.md

Fix link. Simplify URLs.

* Update with both links for working with meta data

* Fixed links
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Update meta box link to new tutorial

* Update README.md

Fix link. Simplify URLs.

* Update with both links for working with meta data

* Fixed links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants