Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codex link i18n #12458

Merged
merged 1 commit into from
Jan 7, 2019
Merged

codex link i18n #12458

merged 1 commit into from
Jan 7, 2019

Conversation

Soean
Copy link
Member

@Soean Soean commented Nov 30, 2018

Description

Adds i18n to the link to excerpt documentation.
Fixes #12418

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Nov 30, 2018
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

To note that we are not adding a new string, this string is already present in core:

<p><?php
	printf(
		/* translators: %s: Codex URL */
		__( 'Excerpts are optional hand-crafted summaries of your content that can be used in your theme. <a href="%s">Learn more about manual excerpts</a>.' ),
		__( 'https://codex.wordpress.org/Excerpt' )
	);
?></p>

@jorgefilipecosta jorgefilipecosta added this to the 4.9 milestone Dec 20, 2018
@youknowriad youknowriad merged commit a3f4362 into master Jan 7, 2019
@youknowriad youknowriad deleted the update/i18n-excerpt-docs-link branch January 7, 2019 08:05
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants