Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to React 16.6.3 #11840

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Update to React 16.6.3 #11840

merged 4 commits into from
Nov 14, 2018

Conversation

youknowriad
Copy link
Contributor

related #11360

@youknowriad youknowriad added the Framework Issues related to broader framework topics, especially as it relates to javascript label Nov 14, 2018
@youknowriad youknowriad added this to the 4.4 milestone Nov 14, 2018
@youknowriad youknowriad self-assigned this Nov 14, 2018
@youknowriad youknowriad requested a review from a team November 14, 2018 08:13
@gziolo
Copy link
Member

gziolo commented Nov 14, 2018

One more folder and we are good to go: phpunit :)

gziolo
gziolo approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's started to be tons of work to upgrade React :)

🚢

@youknowriad youknowriad merged commit d18eca8 into master Nov 14, 2018
@youknowriad youknowriad deleted the update/react branch November 14, 2018 11:59
@gziolo
Copy link
Member

gziolo commented Nov 14, 2018

I tested it locally and it works the same as without this patch. I haven't tried with warnings enabled.

@aduth aduth mentioned this pull request Nov 14, 2018
Closed
12 tasks
@tofumatt tofumatt mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

@youknowriad youknowriad

Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @gziolo